linux-kernel - Re: [PATCH] video: arcfb: fix buffer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101124064649.GQ1522@bicker>
Date:	Wed, 24 Nov 2010 09:46:49 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Paul Mundt <lethal@...ux-sh.org>
Cc:	Vasiliy Kulikov <segoon@...nwall.com>,
	kernel-janitors@...r.kernel.org, Jaya Kumar <jayalk@...works.biz>,
	linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video: arcfb: fix buffer overflow

On Wed, Nov 24, 2010 at 03:25:58PM +0900, Paul Mundt wrote:
> On Sun, Nov 21, 2010 at 08:40:01PM +0300, Vasiliy Kulikov wrote:
> > (count + p) is not checked for integer overflow.  If p < fbmemlength
> > and count == (size_t)(1 - p) (very big unsigned integer) then
> > count + p == 1 < fbmemlength and copy_to_user(base_addr+p, buf, count)
> > overflows base_addr.
> > 
> > Signed-off-by: Vasiliy Kulikov <segoon@...nwall.com>
> 
> Applied, thanks.

The patch is harmless, but the integer overflow would actually be caught
in rw_verify_area().

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/