linux-kernel - Re: [PATCH net-next-2.6 1/17 v2] can: EG20T PCH: Separate Interface Register(IF1/IF2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Nov 2010 11:54:25 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Marc Kleine-Budde <mkl@...gutronix.de>
Cc:	Tomoya MORINAGA <tomoya-linux@....okisemi.com>,
	Wolfgang Grandegger <wg@...ndegger.com>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Christian Pellegrin <chripell@...e.org>,
	Barry Song <21cnbao@...il.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	socketcan-core@...ts.berlios.de, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	andrew.chih.howe.khor@...el.com, qi.wang@...el.com,
	margie.foster@...el.com, yong.y.wang@...el.com,
	kok.howg.ewe@...el.com, joel.clark@...el.com
Subject: Re: [PATCH net-next-2.6 1/17 v2] can: EG20T PCH: Separate
 Interface Register(IF1/IF2)

Le mercredi 24 novembre 2010 à 11:44 +0100, Marc Kleine-Budde a écrit :
> On 11/24/2010 08:33 AM, Tomoya MORINAGA wrote:
> > Separate interface register from whole of register structure.
> > CAN register of Intel PCH EG20T has 2 sets of interface register.
> > To reduce whole of code size, separate interface register.
> > As a result, the number of function also can be reduced.
> 
> I failed to apply your series to david's net-2.6/master. Please resubmit.
> 
> > Signed-off-by: Tomoya MORINAGA <tomoya-linux@....okisemi.com>
> > ---
> >  drivers/net/can/pch_can.c |  442 ++++++++++++++++++++-------------------------
> >  1 files changed, 198 insertions(+), 244 deletions(-)
> > 
> > diff --git a/drivers/net/can/pch_can.c b/drivers/net/can/pch_can.c
> > index 238622a..143f100 100644
> > --- a/drivers/net/can/pch_can.c
> > +++ b/drivers/net/can/pch_can.c
> > @@ -102,6 +102,9 @@
> >  #define PCH_MSK_CTRL_IE_SIE_EIE	0x07
> >  #define PCH_COUNTER_LIMIT	10
> >  
> > +#define PCH_RX_IFREG			0
> > +#define PCH_TX_IFREG			1
> 
> Please make this enum _here_, not in a later patch.
> 

[then, huge part deleted, containing no review, spent some time to
discover this...]

Marc, could you please dont include the whole mail in your replies ?

We have a high Noise Rate on this topic already.

Thanks


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/