linux-kernel - Re: [PATCH] ASoC: nuc900-ac97: fix a memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1290595882.3332.7.camel@odin>
Date:	Wed, 24 Nov 2010 10:51:22 +0000
From:	Liam Girdwood <lrg@...mlogic.co.uk>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Wan ZongShun <mcuos.com@...il.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Subject: Re: [PATCH] ASoC: nuc900-ac97: fix a memory leak

On Wed, 2010-11-24 at 16:44 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  sound/soc/nuc900/nuc900-ac97.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c
> index 293dc74..e00e39d 100644
> --- a/sound/soc/nuc900/nuc900-ac97.c
> +++ b/sound/soc/nuc900/nuc900-ac97.c
> @@ -384,7 +384,6 @@ out0:
>  
>  static int __devexit nuc900_ac97_drvremove(struct platform_device *pdev)
>  {
> -
>  	snd_soc_unregister_dai(&pdev->dev);
>  
>  	clk_put(nuc900_ac97_data->clk);
> @@ -392,6 +391,7 @@ static int __devexit nuc900_ac97_drvremove(struct platform_device *pdev)
>  	release_mem_region(nuc900_ac97_data->res->start,
>  				resource_size(nuc900_ac97_data->res));
>  
> +	kfree(nuc900_ac97_data);
>  	nuc900_ac97_data = NULL;
>  
>  	return 0;


Acked-by: Liam Girdwood <lrg@...mlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/