linux-kernel - Re: [PATCH] ASoC: nuc900-ac97: fix a memory leak

Open Source and information security mailing list archives

Message-ID: <AANLkTikosO52KZ1DP2oAtKJTFja26xLUBw1jDND-j0fk@mail.gmail.com>
Date:	Wed, 24 Nov 2010 19:31:14 +0800
From:	Wan ZongShun <mcuos.com@...il.com>
To:	Liam Girdwood <lrg@...mlogic.co.uk>
Cc:	Axel Lin <axel.lin@...il.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Subject: Re: [PATCH] ASoC: nuc900-ac97: fix a memory leak

2010/11/24 Liam Girdwood <lrg@...mlogic.co.uk>:
> On Wed, 2010-11-24 at 16:44 +0800, Axel Lin wrote:
>> Signed-off-by: Axel Lin <axel.lin@...il.com>
>> ---
>>  sound/soc/nuc900/nuc900-ac97.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c
>> index 293dc74..e00e39d 100644
>> --- a/sound/soc/nuc900/nuc900-ac97.c
>> +++ b/sound/soc/nuc900/nuc900-ac97.c
>> @@ -384,7 +384,6 @@ out0:
>>
>>  static int __devexit nuc900_ac97_drvremove(struct platform_device *pdev)
>>  {
>> -
>>       snd_soc_unregister_dai(&pdev->dev);
>>
>>       clk_put(nuc900_ac97_data->clk);
>> @@ -392,6 +391,7 @@ static int __devexit nuc900_ac97_drvremove(struct platform_device *pdev)
>>       release_mem_region(nuc900_ac97_data->res->start,
>>                               resource_size(nuc900_ac97_data->res));
>>
>> +     kfree(nuc900_ac97_data);
>>       nuc900_ac97_data = NULL;
>>
>>       return 0;
>
>
> Acked-by: Liam Girdwood <lrg@...mlogic.co.uk>

Acked-by: Wan ZongShun <mcuos.com@...il.com>

thanks!

> --
> Freelance Developer, SlimLogic Ltd
> ASoC and Voltage Regulator Maintainer.
> http://www.slimlogic.co.uk
>
>

-- 
*linux-arm-kernel mailing list
mail addr:linux-arm-kernel@...ts.infradead.org
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

* linux-arm-NUC900 mailing list
mail addr:NUC900@...glegroups.com
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
mcuos.com@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives