linux-kernel - Re: [PATCH] memblock: fix memblock_is_region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101124153154.a0e68722.akpm@linux-foundation.org>
Date:	Wed, 24 Nov 2010 15:31:54 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Tomi Valkeinen <tomi.valkeinen@...ia.com>
Cc:	benh@...nel.crashing.org, yinghai@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] memblock: fix memblock_is_region_memory()

On Mon,  8 Nov 2010 13:00:13 +0200
Tomi Valkeinen <tomi.valkeinen@...ia.com> wrote:

> To: benh@...nel.crashing.org, yinghai@...nel.org

wakey wakey!

> memblock_is_region_memory() uses reserved memblocks to search for the
> given region, while it should use the memory memblocks.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@...ia.com>
> ---
>  mm/memblock.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/memblock.c b/mm/memblock.c
> index 400dc62..bdba245 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -683,13 +683,13 @@ int __init_memblock memblock_is_memory(phys_addr_t addr)
>  
>  int __init_memblock memblock_is_region_memory(phys_addr_t base, phys_addr_t size)
>  {
> -	int idx = memblock_search(&memblock.reserved, base);
> +	int idx = memblock_search(&memblock.memory, base);
>  
>  	if (idx == -1)
>  		return 0;
> -	return memblock.reserved.regions[idx].base <= base &&
> -		(memblock.reserved.regions[idx].base +
> -		 memblock.reserved.regions[idx].size) >= (base + size);
> +	return memblock.memory.regions[idx].base <= base &&
> +		(memblock.memory.regions[idx].base +
> +		 memblock.memory.regions[idx].size) >= (base + size);
>  }

What were the runtime effects of this problem?

afacit the only callers are a couple of obscure fbdev drivers.  Do you
know of other callers?

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/