linux-kernel - Re: rcu_read_lock/unlock protect find_task_by_vpid call in migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101125013336.GA2854@redhat.com>
Date:	Wed, 24 Nov 2010 20:33:36 -0500
From:	Dave Jones <davej@...hat.com>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: rcu_read_lock/unlock protect find_task_by_vpid call in
 migrate_pages

On Thu, Nov 25, 2010 at 09:50:37AM +0900, KOSAKI Motohiro wrote:
 
 > > @@ -1315,6 +1316,7 @@ SYSCALL_DEFINE4(migrate_pages, pid_t, pid, unsigned long, maxnode,
 > >  		goto out;
 > >  	}
 > >  	mm = get_task_mm(task);
 > > +	rcu_read_unlock();
 > >  	read_unlock(&tasklist_lock);
 > >  
 > >  	err = -EINVAL;
 > 
 > Thanks reporting. but mmotm seems already has the same patch.

indeed. It's also better than mine, which missed the unlock on error path.

thanks,

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/