linux-kernel - Re: [PATCH] Revert "kconfig: Temporarily disable dependency warnings"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTi=jMWL7z=30AnJ0An2HtygserxDbkzagv5_hU1h@mail.gmail.com>
Date:	Fri, 26 Nov 2010 14:50:10 +0000
From:	Catalin Marinas <catalin.marinas@....com>
To:	Michal Marek <mmarek@...e.cz>
Cc:	Arnaud Lacombe <lacombar@...il.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	randy.dunlap@...cle.com, linux-kbuild@...r.kernel.org,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	xiyou.wangcong@...il.com,
	Mauro Carvalho Chehab <mchehab@...radead.org>
Subject: Re: [PATCH] Revert "kconfig: Temporarily disable dependency warnings"

On 26 November 2010 13:33, Michal Marek <mmarek@...e.cz> wrote:
> On 26.11.2010 13:33, Catalin Marinas wrote:
>> On 25 November 2010 18:09, Arnaud Lacombe <lacombar@...il.com> wrote:
>>> On Thu, Nov 25, 2010 at 12:43 PM, Catalin Marinas
>>> <catalin.marinas@....com> wrote:
>>>> Now, commenting on your patches, you added a new statement, 'visible
>>>> if...' for menus. Can we not change it to something like:
>>>>
>>>> -menu "I2C Algorithms"
>>>> -       depends on !I2C_HELPER_AUTO
>>>> +menu "I2C Algorithms" if !I2C_HELPER_AUTO
>>>>
>>> no because if_expr are translated internally in term of dependency,
>>> which we don't want.
>>
>> That's correct but I was wondering whether we could change this kind
>> of 'if' to a visibility attribute or a weaker dependency and avoid
>> 'select' warnings. This way we wouldn't introduce new keywords to the
>> kconfig language.
>
> I quite like the "visible if" notation because it makes it explicit that
> it only affects the display of the menu and does not add any dependency
> to the data.

That's fine by me. If you like this feature then it could get upstream :)

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/