linux-kernel - Re: The longest build error ever, ever, ever seen :) (Re: linux-next: Tree for November 26)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101128002228.GB4562@suse.de>
Date:	Sat, 27 Nov 2010 16:22:28 -0800
From:	Greg KH <gregkh@...e.de>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Valdis.Kletnieks@...edu,
	Zimny Lech <napohybelskurwysynom2010@...il.com>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Andres More <more.andres@...il.com>,
	Charles Cl?ment <caratorn@...il.com>,
	devel@...verdev.osuosl.org, Mike McCormack <mikem@...g3k.org>,
	Radu Voicilas <rvoicilas@...il.com>
Subject: Re: The longest build error ever, ever, ever seen :) (Re:
 linux-next: Tree for November 26)

On Sun, Nov 28, 2010 at 08:21:26AM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> On Sat, 27 Nov 2010 10:27:23 -0800 Greg KH <gregkh@...e.de> wrote:
> >
> > On Sat, Nov 27, 2010 at 01:12:27PM -0500, Valdis.Kletnieks@...edu wrote:
> > > On Sat, 27 Nov 2010 08:45:55 PST, Greg KH said:
> > > > On Sat, Nov 27, 2010 at 09:56:45AM +0100, Zimny Lech wrote:
> > > > > Ave!
> > > > > 
> > > > > 2010/11/26 Stephen Rothwell <sfr@...b.auug.org.au>:
> > > > > > Hi all,
> > > > > >
> > > > > 
> > > > > OMG, LOL, this one is awesome :) The longest build error ever, ever,
> > > > > ever seen! Fscking awesome, someone gets Guiness World Record :)
> > > > > 
> > > > >   LD      drivers/staging/built-in.o
> > > > > drivers/staging/rtl8192e/built-in.o: In function `rtl8192_setBBreg':
> > > > > (.text+0xae00): multiple definition of `rtl8192_setBBreg'
> > > > > drivers/staging/rtl8192u/built-in.o:(.text+0xa1a0): first defined here
> > > > 
> > > > You built both of these drivers into the kernel, which causes the
> > > > problem.  Try building them as modules, or just one as a module, and
> > > > that will solve the problem.
> > > 
> > > We probably should create some Kconfig magic to prevent this situation?
> > > 
> > > 	depends (othermodule != 'y') || (myself != 'y')
> > > 
> > > or am I on the wrong track here?
> > 
> > Just make each module depend on 'm' so that they can not be built into
> > the kernel, and all should be fine.
> 
> Surely the real fix is to make sure that the global symbols in these
> drivers are unique ...

That would be "ideal" if they both weren't carrying pretty much the
identical wireless stack within them :)

That's a longer-term fix, the "only build as a module" is common for
staging drivers for this very reason.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/