linux-kernel - Re: toshiba_acpi.c: Full TOS1900 device support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinaR4MbArfs20xLZMUjTa32sSLZfzRrnApgiGqS@mail.gmail.com>
Date:	Sat, 27 Nov 2010 17:44:04 -0700
From:	Azael Avalos <coproscefalo@...il.com>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: toshiba_acpi.c: Full TOS1900 device support

Hi there,

Sorry for the late reply.

On Wed, Nov 24, 2010 at 12:17 PM, Matthew Garrett <mjg59@...f.ucam.org> wrote:
> Can you try this (entirely untested) patch and see if it works on your
> system? It's basically your code, but with some of the conditionals
> cleaned up when we already know that information.

The patch works, however, I added a couple lines in order to make it work
on my laptop:

In toshiba_acpi_query_event:
       status = execute_acpi_method(toshiba_acpi.acpi_dev->handle, "INFO",
				    NULL, hotkey);

Here, the handle should be the ACPI device, not the EC

In toshiba_acpi_add:
	/* enable hotkey event */
	hci_write1(HCI_HOTKEY_EVENT, 1, &hci_result);

My model (and a couple others) the ENAB method is empty, and hotkey
activation is done via HCI_HOTKEY_EVENT


Another thing that I've noticed is that "device->device_type" is always zero
for me, I thought that it was supposed to be 1, due to  {"TOS1900", 1}.
So I changed the comparison value to 0 in order to get the hotkeys
reported.


Saludos
Azael


-- 
-- El mundo apesta y vosotros apestais tambien --
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/