[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1291130139.3293.18.camel@odin>
Date:	Tue, 30 Nov 2010 15:15:39 +0000
From:	Liam Girdwood <lrg@...mlogic.co.uk>
To:	Joe Perches <joe@...ches.com>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: Add and use rdev_<level> macros
On Tue, 2010-11-30 at 05:53 -0800, Joe Perches wrote:
> On Tue, 2010-11-30 at 10:52 +0000, Mark Brown wrote:
> > On Mon, Nov 29, 2010 at 05:12:56PM -0800, Joe Perches wrote:
> > > Just to please broonie...
> > > Signed-off-by: Joe Perches <joe@...ches.com>
> > As usual when fixing review issues please revise your original patch
> > rather than posting a fresh patch.
> 
> Here's an earlier comment:
> 
> On Thu, 2010-11-18 at 13:30 +0000, Mark Brown wrote:
> > This looks reasonable, please rebase on top of Daniel's patches and
> > submit it properly (with changelog and so on). 
> 
> Sometimes it's simpler for an upstream maintainer to do
> something like:
> 
> git am -s <patch1.mbox>
> patch -p1 < patch2.mbox
> git commit --amend file
> 
> instead of back and forthing.
> 
> ---
> Use rdev_<level> convenience macros to emit rdev_get_name(rdev)
> along with whatever format/arg... is supplied.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/regulator/core.c |  146 ++++++++++++++++++++-------------------------
>  1 files changed, 65 insertions(+), 81 deletions(-)
> 
Applied.
Thanks
Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Powered by blists - more mailing lists