linux-kernel - Re: [PATCH 2/2] perf tools: fix event parsing of comma-separated tracepoint events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101201083001.GB3140@elte.hu>
Date:	Wed, 1 Dec 2010 09:30:01 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Arnaldo Carvalho de Melo <acme@...radead.org>
Cc:	linux-kernel@...r.kernel.org,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Julia Lawall <julia@...u.dk>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 2/2] perf tools: fix event parsing of comma-separated
 tracepoint events


* Arnaldo Carvalho de Melo <acme@...radead.org> wrote:

> From: Corey Ashford <cjashfor@...ux.vnet.ibm.com>
> 
> There are number of issues that prevent the use of multiple tracepoint events
> being specified in a -e/--event switch, separated by commas.
> 
> For example, perf stat -e irq:irq_handler_entry,irq:irq_handler_exit ...  fails
> because the tracepoint event parsing code doesn't recognize the comma separator
> properly.
> 
> This patch corrects those issues.

One other thing we seem to have forgotten in the perf stat area: could we please 
make Stephane's --big-num feature the default for perf stat? Big numbers are much 
easier to read that way:

Before:

aldebaran:~> perf stat ./loop_100b_instructions

 Performance counter stats for './loop_100b_instructions':

       23958.911461  task-clock-msecs         #      0.998 CPUs 
                 50  context-switches         #      0.000 M/sec
                  2  CPU-migrations           #      0.000 M/sec
                106  page-faults              #      0.000 M/sec
        76647095433  cycles                   #   3199.106 M/sec
       110471119457  instructions             #      1.441 IPC  
        10116354483  branches                 #    422.238 M/sec
             518642  branch-misses            #      0.005 %    
             220770  cache-references         #      0.009 M/sec
              81657  cache-misses             #      0.003 M/sec

       24.006780937  seconds time elapsed

After:

aldebaran:~> perf stat --big-num ./loop_100b_instructions

 Performance counter stats for './loop_100b_instructions':

       23869.990497  task-clock-msecs         #      0.998 CPUs 
                 58  context-switches         #      0.000 M/sec
                 43  CPU-migrations           #      0.000 M/sec
                106  page-faults              #      0.000 M/sec
     76,338,390,893  cycles                   #   3198.091 M/sec
    110,473,163,060  instructions             #      1.447 IPC  
     10,114,252,456  branches                 #    423.723 M/sec
          1,290,825  branch-misses            #      0.013 %    
          1,713,770  cache-references         #      0.072 M/sec
            188,051  cache-misses             #      0.008 M/sec

       23.917757467  seconds time elapsed

perf stat output isnt an ABI.

(Btw., we should probably also add tabular output for scripts. I thought we had that 
- but apparently not.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/