linux-kernel - Re: [patch 3/4] x86: enable the intr-remap fault handling after local apic setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101201085152.GM10050@sequoia.sous-sol.org>
Date:	Wed, 1 Dec 2010 00:51:52 -0800
From:	Chris Wright <chrisw@...s-sol.org>
To:	Suresh Siddha <suresh.b.siddha@...el.com>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	linux-kernel@...r.kernel.org,
	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>,
	Chris Wright <chrisw@...s-sol.org>,
	Max Asbock <masbock@...ux.vnet.ibm.com>,
	indou.takao@...fujitsu.com,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Bjorn Helgaas <bjorn.helgaas@...com>,
	David Woodhouse <dwmw2@...radead.org>, stable@...nel.org
Subject: Re: [patch 3/4] x86: enable the intr-remap fault handling after
 local apic setup

* Suresh Siddha (suresh.b.siddha@...el.com) wrote:
> From: Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>
> Subject: x86: enable the intr-remap fault handling after local apic setup
> 
> Interrupt-remapping gets enabled very early in the boot, as it determines the
> apic mode that the processor can use. And the current code enables the vt-d
> fault handling before the setup_local_APIC(). And hence the APIC LDR registers
> and data structure in the memory may not be initialized. So the vt-d fault
> handling in logical xapic/x2apic modes were broken.
> 
> Fix this by enabling the vt-d fault handling in the end_local_APIC_setup()
> 
> A cleaner fix of enabling fault handling while enabling intr-remapping
> will be addressed for v2.6.38. [ Enabling intr-remapping determines the
> usage of x2apic mode and the apic mode determines the fault-handling
> configuration. ]
> 
> Signed-off-by: Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>
> Signed-off-by: Suresh Siddha <suresh.b.siddha@...el.com>

Acked-by: Chris Wright <chrisw@...s-sol.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/