[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <AANLkTimfSh8QYLr1bvxcKUwtRLRLLM1J3CCn8uYmKY7v@mail.gmail.com>
Date: Sun, 5 Dec 2010 12:11:14 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Andreas Schwab <schwab@...ux-m68k.org>
Cc: Sam Creasey <sammy@...my.net>,
Andrew Morton <akpm@...ux-foundation.org>,
"Linux/m68k" <linux-m68k@...r.kernel.org>,
Linux Kernel Development <linux-kernel@...r.kernel.org>,
linux-mm@...ck.org
Subject: Re: [PATCH/RFC] m68k/sun3: Kill pte_unmap() warnings
On Sun, Oct 31, 2010 at 22:32, Andreas Schwab <schwab@...ux-m68k.org> wrote:
> Geert Uytterhoeven <geert@...ux-m68k.org> writes:
>
>> Which one is preferable?
>>
>> -------------------------------------------------------------------------------
>> Since commit 31c911329e048b715a1dfeaaf617be9430fd7f4e ("mm: check the argument
>> of kunmap on architectures without highmem"), we get lots of warnings like
>>
>> arch/m68k/kernel/sys_m68k.c:508: warning: passing argument 1 of ‘kunmap’ from incompatible pointer type
>>
>> As m68k doesn't support highmem anyway, open code the calls to kmap() and
>> kunmap() (the latter is a no-op) to kill the warnings.
>
> I prefer this one, it matches all architectures without CONFIG_HIGHPTE.
Thx, applied for 2.6.38, with updated commit message.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists