linux-kernel - Re: [PATCH] ASoC: Fix snd_soc_instantiate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 07 Dec 2010 12:38:42 +0000
From:	Liam Girdwood <lrg@...mlogic.co.uk>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	alsa-devel@...a-project.org
Subject: Re: [PATCH] ASoC: Fix snd_soc_instantiate_card error path

On Tue, 2010-12-07 at 17:06 +0800, Axel Lin wrote:
> >From 0443551476ee6fabe45a0fbc7460dca8e0f6a965 Mon Sep 17 00:00:00 2001
> From: Axel Lin <axel.lin@...il.com>
> Date: Tue, 7 Dec 2010 16:12:29 +0800
> Subject: [PATCH] ASoC: Fix snd_soc_instantiate_card error path
> 
> Properly free the resources in the case of snd_card_register failure
> and soc_register_ac97_dai_link failure.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Acked-by: Liam Girdwood <lrg@...mlogic.co.uk>

> ---
> 
> This patch is against linux-next tree.
> 
> In the case of soc_register_ac97_dai_link failure,
> I think we need below fix for Linus's tree:
> Add 
> while (--i >= 0)
> 	soc_unregister_ac97_dai_link(&card->rtd[i]);
> just before goto probe_dai_err;
> Should I also send a patch against Linus's tree?
> 

Yes please.

Thanks

Liam



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/