linux-kernel - Re: [PATCH v2] mach-at91: Support for gms board added

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CFF47A0.8010208@atmel.com>
Date:	Wed, 08 Dec 2010 09:53:52 +0100
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Igor Plyatov <plyatov@...il.com>
CC:	Ryan Mallon <ryan@...ewatersys.com>, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux@...im.org.za,
	linux@....linux.org.uk, costa.antonior@...il.com,
	plagnioj@...osoft.com
Subject: Re: [PATCH v2] mach-at91: Support for gms board added

Hi Igor,

Le 07/12/2010 20:53, Ryan Mallon :
> On 12/08/2010 03:42 AM, Igor Plyatov wrote:
>> * The gms is a board from GeoSIG Ltd company.
>>   It is based on the Stamp9G20 module from Taskit company.
>> * This is a second version of the patch with adjustments according
>>   to comments from Ryan Mallon.
>> * This patch made for Linux 2.6.37-rc5.

First thank you for submitting this board support.

>> Signed-off-by: Igor Plyatov <plyatov@...il.com>
>> ---

[..]

> Couple more comments below.
> Looking at this a bit more closely, the Stamp9G20 is a system on module
> (SoM) board. The MACH_STAMP9G20 option supports the Stamp9G20 on
> taskits's evaluation board and the MACH_PCONTROL_G20 option supports it
> on the PControl carrier board. There is a reasonable amount of code
> replication in each of the board files for the UARTs, NAND, MMC, etc.
> 
> Would it be better to have MACH_STAMPG20/board-stamp-9g20.c contain the
> core support for the Stamp9G20 module and then each of the carrier board
> files contain only the setup/devices found on the carrier board?

I have exactly the same feeling as Ryan. We should make sure 
to factorize as much code as possible for maintenance reasons.

If you need to distinguish between board features, you can 
pass information in system_rev as implemented in this 
board merging commit:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=a6e016f19d393fbe4e040bee8155b03b840fa689

Best regards,
-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/