linux-kernel - Re: [PATCHv3 2/4] ARM: Allow machines to override _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1291839992.12568.31.camel@c-dwalke-linux.qualcomm.com>
Date:	Wed, 08 Dec 2010 12:26:32 -0800
From:	Daniel Walker <dwalker@...eaurora.org>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Russell King - ARM Linux <linux@....linux.org.uk>,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Saravana Kannan <skannan@...eaurora.org>,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	John Stultz <johnstul@...ibm.com>,
	Brian Swetland <swetland@...gle.com>,
	Arve Hj?nnev?g <arve@...roid.com>
Subject: Re: [PATCHv3 2/4] ARM: Allow machines to override __delay()

On Wed, 2010-12-08 at 12:24 -0800, Stephen Boyd wrote:
> On 12/08/2010 11:22 AM, Daniel Walker wrote:
> > On Tue, 2010-12-07 at 20:38 -0800, Stephen Boyd wrote:
> >> +
> >> +static void (*delay_fn)(unsigned long) = delay_loop;
> >> +
> >> +void set_delay_fn(void (*fn)(unsigned long))
> >> +{
> >> +       delay_fn = fn;
> >> +}
> >> +
> >> +/*
> >> + * loops = usecs * HZ * loops_per_jiffy / 1000000
> >> + */
> >> +void __delay(unsigned long loops)
> >> +{
> >> +       delay_fn(loops);
> >> +}
> >>  EXPORT_SYMBOL(__delay);
> > Didn't we already go over this part ? Why are aren't you putting these
> > in a header file ?
> 
> Last time we saw that inlining set_delay_fn() actually increased the
> text size of the kernel. I know it sounds wrong, but its probably due to
> that compiler behavior Russell posted about last month on arm-lkml.

The last time I thought you said there was no size change ? My tests
showed a decrease ..

What compiler optimizations are you talking about ?

Daniel


-- 

Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/