linux-kernel - Re: [RFC PATCH] scatterlist: Initialize the dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101209.120006.189701386.davem@davemloft.net>
Date:	Thu, 09 Dec 2010 12:00:06 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	nicolas.ferre@...el.com
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [RFC PATCH] scatterlist: Initialize the dma_address field with
 invalid dma address

From: Nicolas Ferre <nicolas.ferre@...el.com>
Date: Thu,  9 Dec 2010 14:15:14 +0100

> Initialize the the dma_address field so that it will be possible to test
> its value while using scatterlists. This field will be compatible with
> testing by dma_mapping_error().
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@...el.com>

Please don't do this, it's unjustified and it's going to kill performance.
Even if it were a good change, you should have used the invalid DMA
address definition defined by various architectures instead of a constant.

You should be aware of whether entries in a scatterlist have been setup
by your code path.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/