linux-kernel - Re: [RFC PATCH] ftrace trace event: introduce assignment macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101209200043.GA8448@Krystal>
Date:	Thu, 9 Dec 2010 15:00:43 -0500
From:	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	Li Zefan <lizf@...fujitsu.com>,
	William Cohen <wcohen@...hat.com>,
	Jun'ichi Nomura <j-nomura@...jp.nec.com>,
	Theodore Ts'o <tytso@....edu>, Jason Baron <jbaron@...hat.com>,
	Mel Gorman <mel@....ul.ie>,
	Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	Avi Kivity <avi@...hat.com>, Gleb Natapov <gleb@...hat.com>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	Neil Horman <nhorman@...driver.com>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Kei Tokunaga <tokunaga.keiich@...fujitsu.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Oleg Nesterov <oleg@...hat.com>,
	Masami Hiramatsu <mhiramat@...hat.com>,
	Josh Stone <jistone@...hat.com>,
	Xiao Guangrong <xiaoguangrong@...fujitsu.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Zhaolei <zhaolei@...fujitsu.com>,
	Anton Blanchard <anton@...ba.org>
Subject: Re: [RFC PATCH] ftrace trace event: introduce assignment macros

* Frederic Weisbecker (fweisbec@...il.com) wrote:
> On Thu, Dec 09, 2010 at 11:22:11AM -0500, Mathieu Desnoyers wrote:
> > This patch proposes encapsulation of the raw assignments within TP_fast_assign()
> > by introducing tp_assign() and tp_memcpy() macros. This will allow us to:
> > 
> > - generically filter from input fields,
> > - redefine the field write primitives.
> > 
> > The current macros map directly to the old code. I changed the documentation in
> > tracepoint.txt to reflect these new primitives, but all TRACE_EVENT() users
> > should gradually update their code to use these macro wrappers rather than raw
> > "=" assignments or mempcy() calls.
> > 
[...]
> > ---
> >  include/linux/tracepoint.h |   12 ++++++------
> >  include/trace/ftrace.h     |    6 ++++++
> >  2 files changed, 12 insertions(+), 6 deletions(-)
> > 
> > Index: linux-2.6-lttng.git/include/trace/ftrace.h
> > ===================================================================
> > --- linux-2.6-lttng.git.orig/include/trace/ftrace.h
> > +++ linux-2.6-lttng.git/include/trace/ftrace.h
> > @@ -1,4 +1,10 @@
> >  /*
> > + * Macros mapping tp_assign() and tp_memcpy() to "=" and memcpy.
> > + */
> > +#define tp_assign(dest, src)		__entry->dest = src
> > +#define tp_memcpy(dest, src, len)	memcpy(__entry->dest, src, len)
> 
> Looks good.

Great! Can I resend it without "RFC" with your Acked-by ?

If there is wide-spread agreement on this change, I might soon start rolling out
patches that migrate TRACE_EVENT users to these new primitives.

Thanks,

Mathieu

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/