linux-kernel - Re: [PATCH] coda: kill redundant cast in coda_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1012100016010.11700@pobox.suse.cz>
Date:	Fri, 10 Dec 2010 00:16:28 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	coda@...cmu.edu, codalist@...EMANN.coda.cs.cmu.edu,
	linux-kernel@...r.kernel.org,
	"Peter J. Braam" <braam@...hs.ox.ac.uk>,
	Michael Callahan <callahan@...hs.ox.ac.uk>,
	Peter Braam <braam@...cmu.edu>
Subject: Re: [PATCH] coda: kill redundant cast in coda_alloc_inode()

On Thu, 9 Dec 2010, Jesper Juhl wrote:

> kmem_cache_alloc() returns a void pointer which there is no need to cast.
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>
> ---
>  inode.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/coda/inode.c b/fs/coda/inode.c
> index 5ea57c8..1a49c17 100644
> --- a/fs/coda/inode.c
> +++ b/fs/coda/inode.c
> @@ -45,7 +45,7 @@ static struct kmem_cache * coda_inode_cachep;
>  static struct inode *coda_alloc_inode(struct super_block *sb)
>  {
>  	struct coda_inode_info *ei;
> -	ei = (struct coda_inode_info *)kmem_cache_alloc(coda_inode_cachep, GFP_KERNEL);
> +	ei = kmem_cache_alloc(coda_inode_cachep, GFP_KERNEL);
>  	if (!ei)
>  		return NULL;
>  	memset(&ei->c_fid, 0, sizeof(struct CodaFid));

Applied, thanks Jesper.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/