linux-kernel - Re: [RFC][PATCH 02/10] mm: Remove likely() from mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1292026152.5015.1541.camel@gandalf.stny.rr.com>
Date:	Fri, 10 Dec 2010 19:09:12 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Miles Bader <miles@....org>
Cc:	Joe Perches <joe@...ches.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Nick Piggin <npiggin@...nel.dk>,
	Rik van Riel <riel@...hat.com>,
	Lee Schermerhorn <Lee.Schermerhorn@...com>
Subject: Re: [RFC][PATCH 02/10] mm: Remove likely() from
 mapping_unevictable()

On Fri, 2010-12-10 at 17:08 +0900, Miles Bader wrote:
> Joe Perches <joe@...ches.com> writes:
> > It'd be better to use
> >
> > 	if (!mapping)
> > 		return 0;
> > 	return test_bit(AS_UNEVICTABLE, &mapping->flags);
> >
> > to avoid the unnecessary !!
> 
> How about 
> 
>  	return mapping && test_bit(AS_UNEVICTABLE, &mapping->flags);
> 
> instead...?

I'll just add my current patch as a "likely()" clean up. Any other
change should be separate.

Thanks,

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/