linux-kernel - Re: [PATCH] GPIO_SCH and I2C_SCH: select MFD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101215212104.GA20097@trinity.fluff.org>
Date:	Wed, 15 Dec 2010 21:21:04 +0000
From:	Ben Dooks <ben-i2c@...ff.org>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Jean Delvare <khali@...ux-fr.org>,
	lkml <linux-kernel@...r.kernel.org>,
	akpm <akpm@...ux-foundation.org>, linux-i2c@...r.kernel.org
Subject: Re: [PATCH] GPIO_SCH and I2C_SCH: select MFD_SUPPORT to eliminate
	kconfig warnings

On Wed, Dec 15, 2010 at 12:11:09PM -0800, Randy Dunlap wrote:
> On 12/15/10 01:15, Jean Delvare wrote:
> > Hi Randy,
> > 
> > On Tue, 14 Dec 2010 16:26:56 -0800, Randy Dunlap wrote:
> >> From: Randy Dunlap <randy.dunlap@...cle.com>
> >>
> >> I2C_ISCH and GPIO_SCH need to select MFD_SUPPORT so that the
> >> dependency tree hierarchy is satisfied.  This eliminates the
> >> kconfig warning:
> >>
> >> warning: (I2C_ISCH && I2C && PCI || GPIO_SCH && GPIOLIB && PCI) selects LPC_SCH which has unmet direct dependencies (MFD_SUPPORT && PCI)
> >>

Hmm, it seems that MFD_SUPPORT enables MFD_CORE, and as such, I don't
think MFD_CORE can be selected without the MFD_SUPPORT.

My view would be to add MFD_NEEDED, or NEEDS_MFD which would force
the MFD_SUPPORT and MFD_CORE on in one go.

-- 
Ben Dooks, ben@...ff.org, http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/