linux-kernel - Re: [RFC 1/5] user namespaces: Add a user_namespace as creator/owner of uts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTik2ry7zbRMgiwhrXMYfQ4tr07BW0ODCNbKBMWmc@mail.gmail.com>
Date:	Fri, 17 Dec 2010 18:00:17 +0200
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	"Serge E. Hallyn" <serge@...lyn.com>
Cc:	LSM <linux-security-module@...r.kernel.org>,
	James Morris <jmorris@...ei.org>,
	Kees Cook <kees.cook@...onical.com>,
	containers@...ts.linux-foundation.org,
	kernel list <linux-kernel@...r.kernel.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Michael Kerrisk <michael.kerrisk@...il.com>
Subject: Re: [RFC 1/5] user namespaces: Add a user_namespace as creator/owner
 of uts_namespace

On Fri, Dec 17, 2010 at 5:56 PM, Alexey Dobriyan <adobriyan@...il.com> wrote:
> On Fri, Dec 17, 2010 at 5:24 PM, Serge E. Hallyn <serge@...lyn.com> wrote:
>> +/*
>> + * userns count is 1 for root user, 1 for init_uts_ns,
>> + * and 1 for... ?
>> + */
>>  struct user_namespace init_user_ns = {
>>        .kref = {
>> -               .refcount       = ATOMIC_INIT(2),
>> +               .refcount       = ATOMIC_INIT(3),
>
> +1 is for init_nsproxy ;-)

Err, no.

+1 is to ensure it's never freed, but since allocator will BUG_ON (?) if fed
with static object, maybe it's completely bogus.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/