linux-kernel - Re: [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101218153012.GA1506@polaris.bitmath.org>
Date:	Sat, 18 Dec 2010 16:30:12 +0100
From:	"Henrik Rydberg" <rydberg@...omail.se>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	Guenter Roeck <guenter.roeck@...csson.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>
Subject: Re: [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding
 resources and devices

> Hm. Is this an oops or a lockdep warning?

It is a null-pointer dereference in sysfs_create_file(). Probably the
kernel is asking the same question as I did - do you actually see the
sysfs nodes when testing the patch?

> > So where to attach the sysfs nodes... There is also a userspace issue
> > here, since a lot of applications are hard-wired to
> > /sys/devices/platform/applesmc.768/.
> 
> The correct sysfs ABI is to use the /sys/class interface and the names 
> under there rather than assuming a hardwired platform device path.

Still breaks user-space, but it seems this is already under control.

Thanks,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/