| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4D0CD3A8.7090609@kernel.org> Date: Sat, 18 Dec 2010 16:30:48 +0100 From: Tejun Heo <tj@...nel.org> To: "H. Peter Anvin" <hpa@...or.com> CC: Christoph Lameter <cl@...ux-foundation.org>, lkml <linux-kernel@...r.kernel.org> Subject: [PATCH 3/3] x86: Use this_cpu_inc_return for nmi counter this_cpu_inc_return() saves us a memory access there. Reviewed-by: Tejun Heo <tj@...nel.org> Reviewed-by: Pekka Enberg <penberg@...nel.org> Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@...icios.com> Acked-by: H. Peter Anvin <hpa@...or.com> Acked-by: Tejun Heo <tj@...nel.org> Signed-off-by: Christoph Lameter <cl@...ux.com> --- arch/x86/kernel/apic/nmi.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/apic/nmi.c b/arch/x86/kernel/apic/nmi.c index b387dce..37769cc 100644 --- a/arch/x86/kernel/apic/nmi.c +++ b/arch/x86/kernel/apic/nmi.c @@ -432,8 +432,7 @@ nmi_watchdog_tick(struct pt_regs *regs, unsigned reason) * Ayiee, looks like this CPU is stuck ... * wait a few IRQs (5 seconds) before doing the oops ... */ - __this_cpu_inc(alert_counter); - if (__this_cpu_read(alert_counter) == 5 * nmi_hz) + if (__this_cpu_inc_return(alert_counter) == 5 * nmi_hz) /* * die_nmi will return ONLY if NOTIFY_STOP happens.. */ -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists