linux-kernel - Re: [tip:perf/core] tracing: Only trace sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1293024095.2170.123.camel@laptop>
Date:	Wed, 22 Dec 2010 14:21:35 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	linux-kernel@...r.kernel.org
Cc:	mingo@...hat.com, hpa@...or.com, rostedt@...dmis.org,
	srostedt@...hat.com, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perf/core] tracing: Only trace sched_wakeup if it
 actually work something up

On Wed, 2010-12-22 at 14:19 +0100, Peter Zijlstra wrote:
> On Wed, 2010-12-22 at 13:16 +0000, tip-bot for Steven Rostedt wrote:
> > Commit-ID:  14bc7a06c6175cfa8070a5f5022210b648c3e0a7
> > Gitweb:     http://git.kernel.org/tip/14bc7a06c6175cfa8070a5f5022210b648c3e0a7
> > Author:     Steven Rostedt <srostedt@...hat.com>
> > AuthorDate: Thu, 2 Dec 2010 16:56:14 -0500
> > Committer:  Steven Rostedt <rostedt@...dmis.org>
> > CommitDate: Fri, 3 Dec 2010 10:46:59 -0500
> > 
> > tracing: Only trace sched_wakeup if it actually work something up
> > 
> > Currently the tracepoint sched_wakeup traces the wakeup event even
> > if the wakeup failed to wake anything up. This is quite stupid
> > but it happens because we did not want to add a conditional
> > to the core kernel code that would just slow down the wakeup events.
> > 
> > This patch changes the wakeup tracepoints to use the
> > 
> >  DEFINE_EVENT_CONDITIONAL()
> > 
> > to test the "success" parameter and will only trace the event if
> > the wakeup was successfull.
> > 
> > The success field in the tracepoint is removed since it is no
> > longer needed.
> 
> I NAKed this, its stupid.

And wrong too, I got a patch that makes success:=true, I also got a
patch removing success entirely but people started wanking that their
proglets rely on having it :/

Ideally I'd commit the removal and let whatever breaks break.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/