linux-kernel - Re: [PATCH v2] x86, nmi_watchdog: Remove ARCH_HAS_NMI_WATCHDOG and rely on CONFIG_HARDLOCKUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101222162452.GA23665@elte.hu>
Date:	Wed, 22 Dec 2010 17:24:52 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Don Zickus <dzickus@...hat.com>
Cc:	Peter Zijlstra <peterz@...radead.org>, fweisbec@...il.com,
	LKML <linux-kernel@...r.kernel.org>, akpm@...ux-foundation.org
Subject: Re: [PATCH v2] x86, nmi_watchdog:  Remove ARCH_HAS_NMI_WATCHDOG and
 rely on CONFIG_HARDLOCKUP_DETECTOR


* Don Zickus <dzickus@...hat.com> wrote:

> Tested with
> ARCH=i386: allnoconfig, defconfig, allyesconfig, (various broken configs)
> ARCH=x86_64: allnoconfig, defconfig, allyesconfig, (various broken configs)
> 
> Hopefully, after this patch I won't get any more compile broken emails. :-)
> 
> Signed-off-by: Don Zickus <dzickus@...hat.com>

There's still some assumptions in the oprofile code, which breaks the build with 
your patch applied:

 arch/x86/oprofile/op_model_p4.c:394:4: error: implicit declaration of function ‘release_perfctr_nmi’
 arch/x86/oprofile/op_model_p4.c:403:4: error: implicit declaration of function ‘release_evntsel_nmi’
 arch/x86/oprofile/op_model_p4.c:419:3: error: implicit declaration of function ‘reserve_perfctr_nmi’
 arch/x86/oprofile/op_model_p4.c:428:3: error: implicit declaration of function ‘reserve_evntsel_nmi’

Config attached.

Thanks,

	Ingo

View attachment "config" of type "text/plain" (72231 bytes)