linux-kernel - Re: [PATCH v2] x86, nmi_watchdog: Remove ARCH_HAS_NMI_WATCHDOG and rely on CONFIG_HARDLOCKUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 22 Dec 2010 14:01:08 -0500
From:	Don Zickus <dzickus@...hat.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Peter Zijlstra <peterz@...radead.org>, fweisbec@...il.com,
	LKML <linux-kernel@...r.kernel.org>, akpm@...ux-foundation.org
Subject: Re: [PATCH v2] x86, nmi_watchdog:  Remove ARCH_HAS_NMI_WATCHDOG and
 rely on CONFIG_HARDLOCKUP_DETECTOR

On Wed, Dec 22, 2010 at 05:24:52PM +0100, Ingo Molnar wrote:
> 
> * Don Zickus <dzickus@...hat.com> wrote:
> 
> > Tested with
> > ARCH=i386: allnoconfig, defconfig, allyesconfig, (various broken configs)
> > ARCH=x86_64: allnoconfig, defconfig, allyesconfig, (various broken configs)
> > 
> > Hopefully, after this patch I won't get any more compile broken emails. :-)
> > 
> > Signed-off-by: Don Zickus <dzickus@...hat.com>
> 
> There's still some assumptions in the oprofile code, which breaks the build with 
> your patch applied:
> 
>  arch/x86/oprofile/op_model_p4.c:394:4: error: implicit declaration of function ‘release_perfctr_nmi’
>  arch/x86/oprofile/op_model_p4.c:403:4: error: implicit declaration of function ‘release_evntsel_nmi’
>  arch/x86/oprofile/op_model_p4.c:419:3: error: implicit declaration of function ‘reserve_perfctr_nmi’
>  arch/x86/oprofile/op_model_p4.c:428:3: error: implicit declaration of function ‘reserve_evntsel_nmi’
> 
> Config attached.

Thanks.  I sent a patch to fix this.  Basically they were using
linux/nmi.h instead of asm/nmi.h.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/