linux-kernel - Re: [PATCH 6/6] cpufreq: Evaluate P1 before enter turbo mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101223143859.GA1402@srcf.ucam.org>
Date:	Thu, 23 Dec 2010 14:38:59 +0000
From:	Matthew Garrett <mjg@...hat.com>
To:	Dominik Brodowski <linux@...inikbrodowski.net>,
	Youquan Song <youquan.song@...el.com>, davej@...hat.com,
	cpufreq@...r.kernel.org, venki@...gle.com, arjan@...ux.intel.com,
	lenb@...nel.org, suresh.b.siddha@...el.com, kent.liu@...el.com,
	chaohong.guo@...el.com, linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org,
	Youquan Song <youquan.song@...ux.intel.com>
Subject: Re: [PATCH 6/6] cpufreq: Evaluate P1 before enter turbo mode

On Thu, Dec 23, 2010 at 11:57:30AM +0100, Dominik Brodowski wrote:

> NACK. First of all, why is it only a "turbo mode" if it's 1000 kHz
> difference?

I believe that that's how it's supposed to be defined for Intel systems, 
but you're right that this doesn't belong in generic code. AMD have 
support for enabling/disabling their equivalent functionality through 
sysfs - I'd say that copying that interface and using it to limit the 
set of p-states provided to the core makes more sense.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/