linux-kernel - Re: [PATCH] ACPI Thinkpad: We must always call va_end() after va_start() but do not do so in thinkpad_acpi.c::acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 25 Dec 2010 23:03:22 -0200
From:	Henrique de Moraes Holschuh <hmh@....eng.br>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	ibm-acpi-devel@...ts.sourceforge.net,
	Henrique de Moraes Holschuh <ibm-acpi@....eng.br>,
	Matthew Garrett <mjg@...hat.com>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI Thinkpad: We must always call va_end() after
 va_start() but do not do so in thinkpad_acpi.c::acpi_evalf()

On Fri, 24 Dec 2010, Jesper Juhl wrote:
> In drivers/platform/x86/thinkpad_acpi.c::acpi_evalf() we don't always call 
> va_end() after va_start(). This patch corrects that.

Acked-by: Henrique de Moraes Holschuh <hmh@....eng.br>

Although that codepath is for a driver source bug, so arguably it would
be better to just BUG().

It has never been tested (or hit in practice), I think.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/