linux-kernel - Re: [PATCH] befs: Don't pass huge structs by value.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinkzVs3XSp7cHP0Qhhd8+wuZs-X-yKt1dnZeSiO@mail.gmail.com>
Date:	Sat, 25 Dec 2010 20:26:03 -0500
From:	Will Dyson <will_dyson@...ox.com>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	linux-kernel@...r.kernel.org,
	Makoto Kato <m_kato@....so-net.ne.jp>,
	"Sergey S. Kostyliov" <rathamahata@...4.ru>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] befs: Don't pass huge structs by value.

On Sat, Dec 25, 2010 at 2:27 PM, Jesper Juhl <jj@...osbits.net> wrote:
> Hi there,
>
> 'struct befs_disk_data_stream' is huge (~144 bytes) and it's being passed
> by value in fs/befs/endian.h::cpu_to_fsrun().
>
> It seems to me that it would be better to pass a pointer, no?
> This patch changes the function to take a pointer to the large struct.
>
> Signed-off-by: Jesper Juhl <jj@...osbits.net>

Seems very reasonable to me. Unfortunately, I have no longer have any
befs filesystems to test on either.

-- 
Will Dyson
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/