linux-kernel - Re: [RFC patch 5/5] trace event sched: remove TP_perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110105132856.GB31831@Krystal>
Date:	Wed, 5 Jan 2011 08:28:56 -0500
From:	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Mike Galbraith <efault@....de>,
	Paul Mackerras <paulus@...ba.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [RFC patch 5/5] trace event sched: remove TP_perf_assign

* Peter Zijlstra (a.p.zijlstra@...llo.nl) wrote:
> On Tue, 2011-01-04 at 18:16 -0500, Mathieu Desnoyers wrote:
> > plain text document attachment (trace-event-sched-remove-perf-count.patch)
> > The TP_perf_assign part of 2 scheduler TRACE_EVENT are not used and don't act as
> > TRACE_EVENT fields per se.
> 
> Hrm,. they should be used, include/trace/ftrace.h uses __perf_count().
> If it doesn't actually work them something broke.
> 
> So NAK on removing them.

Good point, a fresh look at perf's use of __perf_count() shows that the __count
and __addr local variables are acutally used. I'm therefore dropping this patch.

Thanks,

Mathieu

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/