linux-kernel - Re: [PATCH] PCI: sysfs: Update ROM to include default owner write access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 5 Jan 2011 09:46:01 -0800
From:	Chris Wright <chrisw@...hat.com>
To:	Alex Williamson <alex.williamson@...hat.com>
Cc:	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	jbarnes@...tuousgeek.org, chrisw@...hat.com, avi@...hat.com
Subject: Re: [PATCH] PCI: sysfs: Update ROM to include default owner write
 access

* Alex Williamson (alex.williamson@...hat.com) wrote:
> The PCI sysfs ROM interface requires an enabling write to access
> the ROM image, but the default file mode is 0400.  The original
> proposed patch adding sysfs ROM support was a true read-only
> interface, with the enabling bit coming in as a feature request.
> I suspect it was simply an oversight that the file mode didn't
> get updated to match the API.

This is often not an issue given normal root capabilities, but once
we strip those capabilities, the default 0400 causes O_RDWR to fail.
As Alex said, given the only way to use the file is to write to it first,
making it writable makes sense.

> Signed-off-by: Alex Williamson <alex.williamson@...hat.com>

Acked-by: Chris Wright <chrisw@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/