linux-kernel - Re: [PATCH] PCI: sysfs: Update ROM to include default owner write access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110107142727.6c59e1ce@jbarnes-desktop>
Date:	Fri, 7 Jan 2011 14:27:27 -0800
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Alex Williamson <alex.williamson@...hat.com>
Cc:	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	chrisw@...hat.com, avi@...hat.com
Subject: Re: [PATCH] PCI: sysfs: Update ROM to include default owner write
 access

On Wed, 05 Jan 2011 10:26:41 -0700
Alex Williamson <alex.williamson@...hat.com> wrote:

> The PCI sysfs ROM interface requires an enabling write to access
> the ROM image, but the default file mode is 0400.  The original
> proposed patch adding sysfs ROM support was a true read-only
> interface, with the enabling bit coming in as a feature request.
> I suspect it was simply an oversight that the file mode didn't
> get updated to match the API.
> 
> Signed-off-by: Alex Williamson <alex.williamson@...hat.com>
> ---
> 
>  drivers/pci/pci-sysfs.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> index 63d5042..8ecaac9 100644
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
> @@ -1149,7 +1149,7 @@ int __must_check pci_create_sysfs_dev_files (struct pci_dev *pdev)
>  		sysfs_bin_attr_init(attr);
>  		attr->size = rom_size;
>  		attr->attr.name = "rom";
> -		attr->attr.mode = S_IRUSR;
> +		attr->attr.mode = S_IRUSR | S_IWUSR;
>  		attr->read = pci_read_rom;
>  		attr->write = pci_write_rom;
>  		retval = sysfs_create_bin_file(&pdev->dev.kobj, attr);

Applied, thanks.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/