linux-kernel - Re: [PATCH] gpio/ml_ioh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <A806957B89494BCC9C6E56726BFC5DE8@hacdom.okisemi.com>
Date:	Wed, 5 Jan 2011 14:24:19 +0900
From:	"Tomoya MORINAGA" <tomoya-linux@....okisemi.com>
To:	"Andrew Morton" <akpm@...ux-foundation.org>
Cc:	"Toshiharu Okada" <toshiharu-linux@....okisemi.com>,
	<kok.howg.ewe@...el.com>, <joel.clark@...el.com>,
	<yong.y.wang@...el.com>, <qi.wang@...el.com>,
	<linux-kernel@...r.kernel.org>,
	"Mark Brown" <broonie@...nsource.wolfsonmicro.com>,
	"Linus Walleij" <linus.walleij@...ricsson.com>,
	"Marc Zyngier" <maz@...terjones.org>,
	"Rabin Vincent" <rabin.vincent@...ricsson.com>,
	"Samuel Ortiz" <sameo@...ux.intel.com>
Subject: Re: [PATCH] gpio/ml_ioh_gpio: ML7213 GPIO driver

Hi Andrew,

On Tuesday, January 04, 2011 6:40 AM, Andrew Morton wrote:
>> + for (i = 0, chip = chip_save; i < 8; i++, chip++) {
> 
> chip = chip_save;
> for (i = 0; i < 8; i++, chip++) {
> 
> is simpler, and simpler is better.

I will modify and post the patch soon.

>> + ret = gpiochip_add(&chip->gpio);
>> + if (ret) {
>> + dev_err(&pdev->dev, "IOH gpio: Failed to register GPIO\n");
>> + goto err_gpiochip_add;
> 
> Here we should run gpiochip_remove() against chips 0 .. i-1, no?

Yes, you are right.
I will modify and post the patch soon.


Thanks,,
---
Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/