linux-kernel - Re: [PATCH] trace event skb remove duplicate null-pointer check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110106183802.GA2335@Krystal>
Date:	Thu, 6 Jan 2011 13:38:02 -0500
From:	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	David Miller <davem@...emloft.net>, rostedt@...dmis.org,
	nhorman@...driver.com, zhaolei@...fujitsu.com,
	linux-kernel@...r.kernel.org, mingo@...e.hu, tglx@...utronix.de
Subject: Re: [PATCH] trace event skb remove duplicate null-pointer check

* Frederic Weisbecker (fweisbec@...il.com) wrote:
> On Thu, Jan 06, 2011 at 10:15:44AM -0800, David Miller wrote:
> > From: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
> > Date: Thu, 6 Jan 2011 12:53:19 -0500
> > 
> > > The check for NULL skb in the kfree_skb trace event is a duplicate from the
> > > check already done in its only caller, kfree_skb(). Remove this duplicate check.
> > > 
> > > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
> > > Acked-by: Neil Horman <nhorman@...driver.com>
> > 
> > Acked-by: David S. Miller <davem@...emloft.net>
> 
> May be you want to take that on the net tree? Looks like more appropriate.
> Of course this can go through the tracing tree as well.

It might be easier to manage the TRACE_EVENT() reshaping (removal of semicolumn,
tp_assign, etc) I am preparing if, at this stage, we merge most of the
include/trace/event patches through a single tree (the tracing tree). Otherwise
we might end up with more commit cross-dependencies between the trees, and
increase the risk of conflicts.

Thanks,

Mathieu

> 
> Thanks.

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/