linux-kernel - Re: [GIT PULL] x86/apic changes for v2.6.38

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=YCJ+=94hBZT4qnS=Q_BnVXFUo-Fr8dCbPUXbk@mail.gmail.com>
Date:	Thu, 6 Jan 2011 16:32:42 -0800
From:	Tony Luck <tony.luck@...el.com>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...e.hu>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Wu Fengguang <fengguang.wu@...el.com>,
	Bjorn Helgaas <bjorn.helgaas@...com>
Subject: Re: [GIT PULL] x86/apic changes for v2.6.38

On Thu, Jan 6, 2011 at 4:17 PM, Yinghai Lu <yinghai@...nel.org> wrote:
> looks ia64 is using struct array with cpu idx for mapping
>
>        node_cpuid[srat_num_cpus].phys_id =
>            (pa->apic_id << 8) | (pa->local_sapic_eid);
>        /* nid should be overridden as logical node id later */
>        node_cpuid[srat_num_cpus].nid = pxm;
>        cpu_set(srat_num_cpus, early_cpu_possible_map);
>        srat_num_cpus++;

Good point.

> +       if (srat_num_cpus >= NR_CPUS) {
> +               printk(KERN_WARNING "NR_CPUS (%d) is too small, not all cpus used.
> %d\n", NR_CPUS);
> +               return;
> +       }
> +

Looks ok - but printk_once() might be better so we don't flood the console
if someone tries running an NR_CPUS=16 kernel on a monster SGI machine.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/