linux-kernel - Re: [PATCH] x86: use PCI method for enabling AMD extended config space before MSR method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110107095920.GO4739@erda.amd.com>
Date:	Fri, 7 Jan 2011 10:59:20 +0100
From:	Robert Richter <robert.richter@....com>
To:	Jan Beulich <JBeulich@...ell.com>
CC:	"Herrmann3, Andreas" <Andreas.Herrmann3@....com>,
	"Roedel, Joerg" <Joerg.Roedel@....com>,
	"mingo@...e.hu" <mingo@...e.hu>,
	JeremyFitzhardinge <jeremy@...p.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"hpa@...or.com" <hpa@...or.com>
Subject: Re: [PATCH] x86: use PCI method for enabling AMD extended
	 config space before MSR method

On 07.01.11 02:40:00, Jan Beulich wrote:
> >>> On 06.01.11 at 18:20, Robert Richter <robert.richter@....com> wrote:
> > On 06.01.11 11:57:35, Jan Beulich wrote:
> >> +#ifdef CONFIG_AMD_NB
> >> +	/* Try the PCI method first. */
> >> +	if (early_pci_allowed()) {
> >> +		unsigned int i, n;
> >> +
> >> +		for (n = i = 0; !n && amd_bus_dev_ranges[i].dev_limit; ++i) {
> >> +			u8 bus = amd_bus_dev_ranges[i].bus;
> >> +			u8 slot = amd_bus_dev_ranges[i].dev_base;
> >> +			u8 limit = amd_bus_dev_ranges[i].dev_limit;
> >> +
> >> +			for (; slot < limit; ++slot) {
> >> +				u32 val = read_pci_config(bus, slot, 3, 0);
> >> +
> >> +				if (!early_is_k8_nb(val))
> >> +					continue;
> >> +
> >> +				val = read_pci_config(bus, slot, 3, 0x8c);
> >> +				if (!(val & (ENABLE_CF8_EXT_CFG >> 32))) {
> >> +					val |= ENABLE_CF8_EXT_CFG >> 32;
> >> +					write_pci_config(bus, slot, 3, 0x8c,
> >> +							 val);
> >> +				}
> >> +				++n;
> >> +			}
> >> +		}
> >> +		pr_info("Extended Config Space enabled on %u nodes\n", n);
> > 
> > Isn't i the number of nodes?
> 
> No, "i" is the number of PCI devices looked at (but only those that
> pass early_is_k8_nb() are of interest).

Right, your code is correct.

Thanks,

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/