linux-kernel - Re: 2.6.37-next - kernel BUG at fs/dcache.c:1363

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <25743.1294420240@localhost>
Date:	Fri, 07 Jan 2011 12:10:40 -0500
From:	Valdis.Kletnieks@...edu
To:	Nick Piggin <npiggin@...il.com>
Cc:	Alexander Viro <viro@...iv.linux.org.uk>,
	Joel Becker <joel.becker@...cle.com>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: 2.6.37-next - kernel BUG at fs/dcache.c:1363

On Fri, 07 Jan 2011 00:12:09 +1100, Nick Piggin said:

> > Thanks. It actually passed in a dentry that appears to have already been
> > used for something. This is not exactly a nice thing for a filesystem to do
> > and probably indicates an underlying bug anyway (or at least something
> > the vfs doesn't guarantee the safety of).
> >
> > Taking a look now.
>
> This patch fixes it here

> config fs: avoid switching ->d_op on live dentry

> Switching d_op on a live dentry is racy in general, so avoid it. In this case
> it is a negative dentry, which is safer, but there are still concurrent ops
> which may be called on d_op in that case (eg. d_revalidate). So in general
> a filesystem may not do this. Fix configfs so as not to do this.

Confirming this patch fixes the crash I was seeing, so now I'm off to try to
finish bisecting my way through the other issue I was seeing...

Content of type "application/pgp-signature" skipped