linux-kernel - RE: [PATCH v2] input: tegra-kbc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1FC56210173BB445BD77F608D6FB8D03165A008053@HQMAIL03.nvidia.com>
Date:	Thu, 6 Jan 2011 18:49:45 -0800
From:	Rakesh Iyer <riyer@...dia.com>
To:	'Randy Dunlap' <rdunlap@...otime.net>,
	Jesper Juhl <jj@...osbits.net>
CC:	"tsoni@...eaurora.org" <tsoni@...eaurora.org>,
	"shubhrajyoti@...com" <shubhrajyoti@...com>,
	"ccross@...roid.com" <ccross@...roid.com>,
	"konkers@...roid.com" <konkers@...roid.com>,
	"olof@...om.net" <olof@...om.net>, Andrew Chew <AChew@...dia.com>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>
Subject: RE: [PATCH v2] input: tegra-kbc - Add tegra keyboard driver



> -----Original Message-----
> From: linux-kernel-owner@...r.kernel.org [mailto:linux-kernel-owner@...r.kernel.org] On
> Behalf Of Randy Dunlap
> Sent: Thursday, January 06, 2011 2:27 PM
> To: Jesper Juhl
> Cc: Rakesh Iyer; tsoni@...eaurora.org; shubhrajyoti@...com; ccross@...roid.com;
> konkers@...roid.com; olof@...om.net; Andrew Chew; linux-tegra@...r.kernel.org; linux-
> kernel@...r.kernel.org; linux-input@...r.kernel.org
> Subject: Re: [PATCH v2] input: tegra-kbc - Add tegra keyboard driver
> 
> On Thu, 6 Jan 2011 23:15:01 +0100 (CET) Jesper Juhl wrote:
> 
> > > +fail:
> > > +	if (kbc->irq >= 0)
> > > +		free_irq(kbc->irq, pdev);
> > > +	if (kbc->idev)
> > > +		input_free_device(kbc->idev);
> >
> > As far as I can tell input_free_device() deals gracefully with being
> > passed a null pointer, so the 'if' seems superfluous.
> >
> >
> > --
> > Jesper Juhl <jj@...osbits.net>            http://www.chaosbits.net/
> > Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
> > Plain text mails only, please.
> + Please trim replies to the relevant part(s) of patches.
> 
> 
> thnx,
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Is having this check really an issue? 
Can't input_free_device change in the future so that NULL as a parameter does cause undesirable side-effects?

Regards
Rakesh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/