linux-kernel - Re: [PATCH v2] input: tegra-kbc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 6 Jan 2011 14:27:14 -0800
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	Rakesh Iyer <riyer@...dia.com>, tsoni@...eaurora.org,
	shubhrajyoti@...com, ccross@...roid.com, konkers@...roid.com,
	olof@...om.net, achew@...dia.com, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH v2] input: tegra-kbc - Add tegra keyboard driver

On Thu, 6 Jan 2011 23:15:01 +0100 (CET) Jesper Juhl wrote:

> > +fail:
> > +	if (kbc->irq >= 0)
> > +		free_irq(kbc->irq, pdev);
> > +	if (kbc->idev)
> > +		input_free_device(kbc->idev);
> 
> As far as I can tell input_free_device() deals gracefully with being 
> passed a null pointer, so the 'if' seems superfluous.
> 
> 
> -- 
> Jesper Juhl <jj@...osbits.net>            http://www.chaosbits.net/
> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
> Plain text mails only, please.
+ Please trim replies to the relevant part(s) of patches.


thnx,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/