linux-kernel - Re: [PATCH 4/5] Coding style in serial2002 Patch that resolves braces and KERN_ warnings by checkpatch.pl Signed-off-by: Michael Ahern

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1294617365.7495.193.camel@Joe-Laptop>
Date:	Sun, 09 Jan 2011 15:56:05 -0800
From:	Joe Perches <joe@...ches.com>
To:	ahern.michael.t@...il.com
Cc:	gregkh@...e.de, u.kleine-koenig@...gutronix.de, julia@...u.dk,
	nikai@...ai.net, morgan.gatti@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] Coding style in serial2002 Patch that resolves
 braces and KERN_ warnings by checkpatch.pl Signed-off-by: Michael Ahern

On Mon, 2011-01-10 at 10:03 +1100, ahern.michael.t@...il.com wrote:
> From: mah <ahern.michael.t@...il.com>

Hi Michael, just trivia.

>  drivers/staging/comedi/drivers/serial2002.c |  206 ++++++++++++---------------
> @@ -451,23 +454,23 @@ static int serial_2002_open(struct comedi_device *dev)
>  				command = (data.value >> 8) & 0x3;
>  				switch (kind) {
>  				case 1:{
> -						cur_config = dig_in_config;
> +					cur_config = dig_in_config;
>  					}
>  					break;
>  				case 2:{

You could remove the braces from all the case labels as well.

[]

> +						switch (unit) {
> +						case 0:{
> +							min = min * 1000000;

Perhaps *= 1000000 and *= 1000


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/