linux-kernel - Re: [PATCH 1/5] Staging: comedi: fix line-length coding style issue in usbduxfast.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110110063616.GB3016@suse.de>
Date:	Sun, 9 Jan 2011 22:36:16 -0800
From:	Greg KH <gregkh@...e.de>
To:	ahern.michael.t@...il.com
Cc:	u.kleine-koenig@...gutronix.de, julia@...u.dk, nikai@...ai.net,
	morgan.gatti@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] Staging: comedi: fix line-length coding style
 issue in usbduxfast.c

On Mon, Jan 10, 2011 at 10:03:12AM +1100, ahern.michael.t@...il.com wrote:
> From: mah <ahern.michael.t@...il.com>

Please put your "real" name here, the same one you put down below in the
Signed-off-by: line.

> This patch to usbduxfast.c file that fixes warnings found by checkpatch.pl tool

Which warnings?

> -static void usbduxfast_firmware_request_complete_handler(const struct firmware
> +static void usbduxfast_firmware_req_complete_handler(const struct firmware
>  							 *fw, void *context)
>  {
>  	struct usbduxfastsub_s *usbduxfastsub_tmp = context;
> @@ -1577,7 +1585,7 @@ static int usbduxfastsub_probe(struct usb_interface *uinterf,
>  				      &udev->dev,
>  				      GFP_KERNEL,
>  				      usbduxfastsub + index,
> -				      usbduxfast_firmware_request_complete_handler);
> +				      usbduxfast_firmware_req_complete_handler);

Renaming the function name just to make the line-length work isn't ok.
Just don't make this change.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/