linux-kernel - Re: linux-next: build warnings after merge of the tty tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTimd1oOzHau3OoyfLzNTRKJTpwxU5-+bQM6Xssm=@mail.gmail.com>
Date:	Mon, 10 Jan 2011 15:55:35 +0100
From:	Kay Sievers <kay.sievers@...y.org>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Greg KH <greg@...ah.com>, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org, Linus <torvalds@...ux-foundation.org>
Subject: Re: linux-next: build warnings after merge of the tty tree

On Mon, Jan 10, 2011 at 02:59, Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> Hi Greg,
>
> On Sun, 9 Jan 2011 16:56:01 -0800 Greg KH <greg@...ah.com> wrote:
>>
>> Yes, Kay just sent me a patch to fix this, which I will queue up after
>> .38-rc1 is out.
>
> It is surely a pretty obvious patch, why not just do a quick test and
> send it on to Linus (or at least your tty-current tree)?
>
> /me gets annoyed by more warnings than necessary - especially when they
> should have never been introduced in the first place.

Honestly, just disable these mindless warnings. They *might* be a hint
for a developer, but they should not be triggered in any non-manual
build.

These warnings usually just misguide people to make make random
trivial things fatal at bootup, which even prevent a box from coming
up and allow to find the real error. If these return values would
really be important, the called function would log the error itself,
not force the caller.

I personally think they are as useless as the dumb 80 char limit
checkpatch likes to warn about. It just makes things worse, hard to
read -- while it possibly should just warn about to many indents,
never the line length.

Like the must_check nonsense, it's all stuff with well-intended, but
with really bad results in reality.

People should really stop imposing these sick rules everywhere in
tools -- everybody of us has enough personal issues already, I really
don't need our software to throw the issues of other people at me on
top. :)

Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/