linux-kernel - Re: [PATCH 0/3] x86, usb, pci: Disable usb legacy support early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110110102759.3780cfe6@jbarnes-desktop>
Date:	Mon, 10 Jan 2011 10:27:59 -0800
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Greg KH <greg@...ah.com>
Cc:	Yinghai Lu <yinghai@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	linux-usb@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Sarah Sharp <sarah.a.sharp@...ux.intel.com>
Subject: Re: [PATCH 0/3] x86, usb, pci: Disable usb legacy support early

On Mon, 10 Jan 2011 07:57:24 -0800
Greg KH <greg@...ah.com> wrote:

> On Sun, Jan 09, 2011 at 11:58:58AM -0800, Yinghai Lu wrote:
> > move quirks for usb handoff early for x86.
> > 
> > So we can get stable result when trying to calibrate apic timer with pm-timer.
> 
> Is this a real problem today?  What is the symptom of the issue?  Where
> was it reported as a problem?

Yes, please give us a rationale for all this mess.  I really don't like
the sleep wrappers or the "early" PCI device; would it be easier to
extract some of the core disabling MMIO from the quirks and re-use it
for a totally separate set of early quirk functions?  Like Ben
suggested, making it totally arch specific would be a good option,
though presumably most arches don't need this (again if you explained
why/when this was needed maybe we could come up with a better
solution, or just ignore the problem if you're trying to fix a
pre-production board again with all sorts of broken stuff).

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/