linux-kernel - Re: [PATCH] new UDPCP Communication Protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1294779977.3447.3.camel@edumazet-laptop>
Date:	Tue, 11 Jan 2011 22:06:17 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Stefani Seibold <stefani@...bold.net>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	davem@...emloft.net, netdev@...r.kernel.org, shemminger@...tta.com,
	jj@...osbits.net, daniel.baluta@...il.com, jochen@...hen.org,
	hagen@...u.net, torvalds@...ux-foundation.org, pavel@....cz
Subject: Re: [PATCH] new UDPCP Communication Protocol

Le mardi 11 janvier 2011 à 21:50 +0100, Stefani Seibold a écrit :
> Am Dienstag, den 11.01.2011, 18:01 +0100 schrieb Eric Dumazet:
> > Le mardi 11 janvier 2011 à 17:48 +0100, stefani@...bold.net a écrit :
> > > From: Stefani Seibold <stefani@...bold.net>
> > > 
> > ...
> > > The implementation is clean and has absolut no side effects to the network
> > > subsystems so i ask for merge it into linux, mm-tree or linux-next.
> > > 
> > > The patch is against the current linux git tree
> > > 
> > > - Stefani
> > > 
> > > Signed-off-by: Stefani Seibold <stefani@...bold.net>
> > > ---
> > >  
> > 
> > Reading again UDPCP specs, I find it is IPv4/IPv6 agnostic
> > 
> > You copied IPv4 UDP code, so this only handles IPv4...
> > 
> 
> Right, but currently there is no need for an IPV6 implementation, non of
> our base station provide it and non of our mobile network customers use
> it.
> 
> If it will be required in the future it will be implemented.
> 
> 

All I wanted to point out is the implementation you did, using a copy of
code instead of stacked layer, makes this ipv6 a whole rewrite.

Better understand know the implications, before code inclusion.

I understand your code satisfies your immediate needs (and companies
that paid this development), but we should make a step forward in code
reuse.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/