linux-kernel - Re: [PATCH] strncpy() will not \0 terminate result

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110113224627.GA15000@pengutronix.de>
Date:	Thu, 13 Jan 2011 23:46:27 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	Tony Finch <dot@...at.at>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] strncpy() will not \0 terminate result

On Thu, Jan 13, 2011 at 11:35:39PM +0100, Jesper Juhl wrote:
> Hi,
> 
> Mpass() in scripts/unifdef.c has this code:
>   strncpy(keyword, "if  ", 4);
> this will fail to \0 terminate the destination.
> Following patch should fix that up.
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>

Thanks for fixing those issues. If you could spend a few more seconds on the
subject line (missing sth like "scripts/unifdef"-prefix; I initially was
fearing the bug was in lib/string.c) and the commit-message (which reads like a
mail), that would be helpful for reviewers.

Kind regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)