linux-kernel - Re: [PATCH] strncpy() will not \0 terminate result

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1101132347540.11347@swampdragon.chaosbits.net>
Date:	Thu, 13 Jan 2011 23:48:35 +0100 (CET)
From:	Jesper Juhl <jj@...osbits.net>
To:	Wolfram Sang <w.sang@...gutronix.de>
cc:	Tony Finch <dot@...at.at>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] strncpy() will not \0 terminate result

On Thu, 13 Jan 2011, Wolfram Sang wrote:

> On Thu, Jan 13, 2011 at 11:35:39PM +0100, Jesper Juhl wrote:
> > Hi,
> > 
> > Mpass() in scripts/unifdef.c has this code:
> >   strncpy(keyword, "if  ", 4);
> > this will fail to \0 terminate the destination.
> > Following patch should fix that up.
> > 
> > Signed-off-by: Jesper Juhl <jj@...osbits.net>
> 
> Thanks for fixing those issues. If you could spend a few more seconds on the
> subject line (missing sth like "scripts/unifdef"-prefix; I initially was
> fearing the bug was in lib/string.c) and the commit-message (which reads like a
> mail), that would be helpful for reviewers.
> 
Yeah, I don't know what happened when I wrote that subject - it's quite 
bad. Sorry.

-- 
Jesper Juhl <jj@...osbits.net>            http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/