linux-kernel - Re: [PATCH] configfs: change depends -> select SYSFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1295214807.22813.57.camel@haakon2.linux-iscsi.org>
Date:	Sun, 16 Jan 2011 13:53:27 -0800
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	Joel Becker <jlbec@...lplan.org>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	James Bottomley <James.Bottomley@...e.de>
Subject: Re: [PATCH] configfs: change depends -> select SYSFS

On Sun, 2011-01-16 at 14:11 +0100, Stefan Richter wrote:
> On Jan 15 Nicholas A. Bellinger wrote:
> > This patch changes configfs to select SYSFS to fix the following:
> > 
> > warning: (TARGET_CORE && GFS2_FS) selects CONFIGFS_FS which has unmet direct dependencies (SYSFS)
> 
> Why don't you fix target-core's Kconfig instead?

The thought here was that since modern configfs is mounted
at /sys/kernel/config/, selecting SYSFS by default when building
CONFIGFS_FS made the most sense for existing configfs consumers.

> > This patch also fixes whitespace breakage in the 'help' section.
> 
> There is no whitespace breakage in fs/configfs/Kconfig.

Fixed in scsi-post-merge-2.6.git/for-linus.  Thanks for your comments!

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/