linux-kernel - Re: [PATCH] configfs: change depends -> select SYSFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 17 Jan 2011 00:06:59 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	Joel Becker <jlbec@...lplan.org>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	James Bottomley <James.Bottomley@...e.de>
Subject: Re: [PATCH] configfs: change depends -> select SYSFS

On Jan 16 Nicholas A. Bellinger wrote:
> On Sun, 2011-01-16 at 14:11 +0100, Stefan Richter wrote:
> > On Jan 15 Nicholas A. Bellinger wrote:
> > > This patch changes configfs to select SYSFS to fix the following:
> > > 
> > > warning: (TARGET_CORE && GFS2_FS) selects CONFIGFS_FS which has unmet direct dependencies (SYSFS)
> > 
> > Why don't you fix target-core's Kconfig instead?
> 
> The thought here was that since modern configfs is mounted
> at /sys/kernel/config/, selecting SYSFS by default when building
> CONFIGFS_FS made the most sense for existing configfs consumers.

I for one think that layered "select" directives will open too many cans
of worms.

Best don't use select at all.

If you use it, select only options that don't depend on anything else.

If you feel that people really want you to provide a select for them which
selects something that in turn depends on other things, then I suggest you
rather let your own option depend on these lower dependencies:

config HIGHLEVEL_FEATURE
	tristate "some driver"
	depends on SYSFS  # because CONFIGFS depends on it
	select CONFIGFS
-- 
Stefan Richter
-=====-==-== ---= =---=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/