linux-kernel - Re: [tip:core/urgent] rcu: avoid pointless blocked-task warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110116001516.GB2229@linux.vnet.ibm.com>
Date:	Sat, 15 Jan 2011 16:15:16 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	linux-kernel@...r.kernel.org, mingo@...hat.com, hpa@...or.com,
	paul.mckenney@...aro.org, rmk+kernel@....linux.org.uk,
	weber@...science.de, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:core/urgent] rcu: avoid pointless blocked-task warnings

On Sat, Jan 15, 2011 at 03:28:57PM +0100, Ingo Molnar wrote:
> 
> * tip-bot for Paul E. McKenney <paul.mckenney@...aro.org> wrote:
> 
> > Commit-ID:  b24efdfdf679cf9b05947c531971905fc727dd40
> > Gitweb:     http://git.kernel.org/tip/b24efdfdf679cf9b05947c531971905fc727dd40
> > Author:     Paul E. McKenney <paul.mckenney@...aro.org>
> > AuthorDate: Wed, 12 Jan 2011 14:18:11 -0800
> > Committer:  Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> > CommitDate: Fri, 14 Jan 2011 04:58:08 -0800
> > 
> > rcu: avoid pointless blocked-task warnings
> > 
> > If the RCU callback-processing kthread has nothing to do, it parks in
> > a wait_event().  If RCU remains idle for more than two minutes, the
> > kernel complains about this.  This commit changes from wait_event()
> > to wait_event_interruptible() to prevent the kernel from complaining
> > just because RCU is idle.
> 
> Btw., a sidenote, it's not just about the blocked-tasks lockup detector warning, 
> uninterruptible sleeps will also artificially inflate the load average of the box, 
> +1.0 per such task. So it's definitely a bug to sleep for a very long time 
> uninterruptible.

Good point, and I have made the corresponding change in the in-progress
TREE_PREEMPT_RCU variant of RCU priority boosting.  Some thought will be
required when merging SRCU into the Tiny and Tree RCU implementations.  ;-)

								Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/